Skip to content

chore: update test to ensure button is visible before clicking #31864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jun 11, 2025

Additional details

This Test Replay is not showing the element as visible - may be some timing issue because it shouldn't actually click the button, but I want to be able to see this screen and have it processed for UI Cov and a11y views also.

This PR updates the test to assert it is visible before clicking and also updates an 'exist' assertion to 'be.visible'

Screenshot 2025-06-11 at 9 06 26 AM

Screenshot 2025-06-11 at 9 57 02 AM

Steps to test

  • runs.cy.ts specfile passes and has button visible in Test Replay

How has the user experience changed?

N/A

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Jun 11, 2025
Copy link

cypress bot commented Jun 11, 2025

cypress    Run #62983

Run Properties:  status check passed Passed #62983  •  git commit c9f97cae9f: chore: update test to ensure button is visible before clicking
Project cypress
Branch Review request-access-visible
Run status status check passed Passed #62983
Run duration 15m 06s
Commit git commit c9f97cae9f: chore: update test to ensure button is visible before clicking
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 610
View all changes introduced in this branch ↗︎
UI Coverage  0%
  Untested elements 4  
  Tested elements 0  
Accessibility  97.09%
  Failed rules  0 critical   1 serious   0 moderate   0 minor
  Failed elements 4  

@jennifer-shehane jennifer-shehane merged commit 40000f1 into develop Jun 12, 2025
93 of 95 checks passed
@jennifer-shehane jennifer-shehane deleted the request-access-visible branch June 12, 2025 14:06
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 17, 2025

Released in 14.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants